This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR libgomp/27254
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Thu, 15 Jun 2006 19:03:37 -0700
- Subject: Re: [patch] Fix PR libgomp/27254
- References: <200606140049.k5E0n1JF002777@hiauly1.hia.nrc.ca>
On Tue, Jun 13, 2006 at 08:49:01PM -0400, John David Anglin wrote:
> The enclosed patch fixes PR libgomp/27254. On PA-RISC, locks need to
> be explicitly initialized or they won't work. Carlos O'Donnell noticed
> in discussing this PR that we weren't initializing the locks used for
> internal units. As a result, when the code tries to unlock the lock,
> it appears to be locked but never in fact gets unlocked by any thread.
> This results in the test spinning forever.
>
> The enclosed change provides an initialized and locked lock for internal
> units. I believe that locking the lock provides the correct semantics
> as per the description in unit.c.
>
> The change has been tested on the trunk on hppa-unknown-linux-gnu with
> no regressions.
>
> Ok?
>
Dave, the patch looks ok to me. You, however, might want to
directly ping Jakub who did the locking of libgfortran. If
Jakub doesn't response in a reasonable amount of time, then
go ahead an commit.
--
Steve