This is the mail archive of the
mailing list for the GCC project.
Patch queue and reviewing (Was Re: Generator programs can only be built with optimization enabled?)
- From: Daniel Berlin <dberlin at dberlin dot org>
- To: Eric Botcazou <ebotcazou at libertysurf dot fr>
- Cc: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>, gcc at gcc dot gnu dot org, Mark Mitchell <mark at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 13 Jun 2006 23:24:32 -0400
- Subject: Patch queue and reviewing (Was Re: Generator programs can only be built with optimization enabled?)
- References: <448C7B05.email@example.com> <448D9BE9.firstname.lastname@example.org> <448E652E.email@example.com> <firstname.lastname@example.org>
> IMHO this PR is a striking example of the *major* problems we have been having
> in the patch reviewing department for quite some time.
I don't disagree in this case.
Not only was this patch submitted in march and not reviewed, it was even
pinged on march 29th by someone *else*.
It seems most undirected pings go ignored, probably because nobody
realizes they are supposed to be looking at this patch.
At least, i hope this is why.
The patch queue can now tell who can review a given patch (it guesses
matching the maintenance area you say the patch is for when adding to
the queue against regexps for each maintenance area).
It knows the difference between global and non-global maintainers.
Given this, it would be trivial to make it able to generate, for
example, an RSS feed (Or it could send them emails) for a maintainer
that they can subscribe to which will have new items when they have new
patches they can review.
Does anyone believe this would help make sure patches stop dropping
through the cracks?
It can also tell you who to copy on a ping email to make sure it
actually goes to a maintainer.
the interface is under construction, but "okay" for casual use.
http://www.dberlin.org/patches/patches/maintainer_list/745 would be the
one for this patch.
I already tried generating mass-ping emails for patches that have been
outstanding > 2 weeks on the patch queue, but this didn't seem to help.
I could try generating the ping mails for single patches automatically,
and try to randomly disperse them so that you can't just ignore some
email bomb of ping emails, but this seems like it should be unnecessary.
Past the above, I have no better ideas for getting patches reviewed
other than appointing more maintainers.