This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix PR target/27863: ICE in check_cfg, at haifa-sched.c:4615


Richard Guenther wrote:

On Thu, 8 Jun 2006, Maxim Kuvyrkov wrote:



Vladimir Makarov wrote:


Maxim Kuvyrkov wrote:


2006-06-07 Maxim Kuvyrkov <mkuvyrkov@ispras.ru>

   PR target/27863
   * haifa-sched.c (unlink_other_notes, unlink_line_notes): Update basic
   block boundaries.



The patch is ok. You can commit it into the mainline.


Thanks.

Regtested on i686-pc-linux-gnu. Committed to the trunk.



I wonder why you tested this on i686 when the PR is for target ia64. Can you also add the reduced testcase to gcc.c-torture/compile?



Maxim, please don't disable bootstrap when submitting a patch to the main line. You should check other major platforms too (like x86, x86_64, and ppc if you have them).

I can guess that you put gcc_asserts as in move_insn but unlink_other_notes is called not for all basic block (some notes has no bb field).

I am afraid you broke not only i64 but other targets too. So please fix this as soon as possible. I'll wait for the patch.

Vlad


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]