This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH c/4.2] Fix PR c/27273
- From: Roger Sayle <roger at eyesopen dot com>
- To: Dirk Mueller <dmuell at gmx dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 29 May 2006 12:49:52 -0600 (MDT)
- Subject: Re: [PATCH c/4.2] Fix PR c/27273
On Fri, 19 May 2006, Dirk Mueller wrote:
> 2006-05-19 Dirk Mueller <firstname.lastname@example.org>
> PR c/27273
> * c-common.c (convert_and_check): only track TREE_CONSTANT_OVERFLOW
> for CONSTANT_CLASS_P expressions.
> * gcc.dg/overflow-warn-5.c: New testcase.
This is OK for mainline, though please fix the capitalization of "Only"
in the ChangeLog entry when you commit.
Though technically this file is part of the C/C++ front-ends, I've now
been asked off-list several times by different people to review/approve
it to resolve a common ICE-on-valid on mainline. It's also been pinged
several times without response from the C/GWP maintainership. Hopefully
no-one will object if I stretch my authority by claiming this patch is
"obvious" to a middle-end maintainer. :-)
Thanks for fixing this.