This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFT/RFA] bashjar (take 3)

From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
To: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Tom Tromey <tromey at redhat dot com>, Andreas Schwab <schwab at suse dot de>
Date: Tue, 23 May 2006 18:30:57 +0200
Subject: Re: [RFT/RFA] bashjar (take 3)
References: <e2u1im$niv$1@sea.gmane.org> <20060502192044.GD1691@iam.uni-bonn.de> <4471E06C.6010300@lu.unisi.ch> <20060522165917.GG7686@iam.uni-bonn.de> <20060523151925.GF1709@iam.uni-bonn.de> <447331C1.1090509@lu.unisi.ch>

Hi Paolo,

* Paolo Bonzini wrote on Tue, May 23, 2006 at 06:01:05PM CEST:
>
> The attached script incorporates the remaining fixes from your and 
> Andreas' review.  Only change, I've set IFS with
> 
> IFS=" ""<tab>""
> "

Yes, that's fine.

I noticed one copy buglet: this still contains the M4 quotation:

>   alias -g '${1+"$[@]"}'='"$[@]"'

and should be

    alias -g '${1+"$@"}'='"$@"'

Other than that, looks good to me (untested).

Cheers,
Ralf

References:
- Re: [RFT/RFA] bashjar patch
  - From: Ralf Wildenhues
- Re: [RFT/RFA] bashjar patch
  - From: Paolo Bonzini
- Re: [RFT/RFA] bashjar patch
  - From: Ralf Wildenhues
- Re: [RFT/RFA] bashjar patch
  - From: Ralf Wildenhues
- Re: [RFT/RFA] bashjar (take 3)
  - From: Paolo Bonzini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]