Re: [PATCH] Add support for html/install-html.

[Alexandre Oliva <aoliva at redhat dot com>]

On May 19, 2006, "Carlos O'Donell" <carlos@codesourcery.com> wrote:

> libjava/classpath/

I'm not sure I can or should approve this, but the rest is ok, except
for...

> Index: gcc/Makefile.in

> -$(htmldir)/%/index.html: %.texi
> +# Note: lang.html is a special target which triggers language fragment
> +#       html builds. It is not included in HTMLS because we do not install
> +#       language html files.
> +html:: $(HTMLS) lang.html
> +
> +$(gcc_htmldir)/%: %.texi
>  	$(mkinstalldirs) $(@D)
> -	rm -f $(@D)/*
> -	$(TEXI2HTML) -I $(abs_docdir) -I $(abs_docdir)/include -o $(@D) $<
> +	rm -f $(@)/*
> +	$(TEXI2HTML) -I $(abs_docdir) -I $(abs_docdir)/include -o $(@) $<
 
>  # Duplicate entry to handle renaming of gccinstall
> -$(htmldir)/gccinstall/index.html: $(TEXI_GCCINSTALL_FILES)
> +$(gcc_htmldir)/gccinstall: $(TEXI_GCCINSTALL_FILES)
>  	$(mkinstalldirs) $(@D)
> -	echo rm -f $(@D)/*
> -	$(TEXI2HTML) -I $(abs_docdir) -I $(abs_docdir)/include -o $(@D) $<
> +	echo rm -f $(@)/*
> +	$(TEXI2HTML) -I $(abs_docdir) -I $(abs_docdir)/include -o $(@) $<
 
I'd rather spell $(@) as $@.  The change from $(@D) to $@ got me
confused for a moment, but now i see what you're doing.

That said, I don't think I like the idea of directories as targets.
They seem too fragile.  Any reason to have decided to change it from
<dir>/index.html to just <dir>?  If not, I'd rather keep it the way it
was.

Ok otherwise.

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
Secretary for FSF Latin America        http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}