This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix spurious failure of g++.dg/other/unused1.C


> Andrew Pinski <pinskia@physics.uc.edu> writes:
> 
> >> 
> >> ia64 uses stringz instead of string for STRING_ASM_OP, causing a spurious
> >> testsuite failure.  Tested on ia64-suse-linux and committed as obvious.
> >> 
> >
> > This also fixes hppa and PR 27611.

I don't believe it fixes the failure under hpux either.  It uses `STRING '.
See output_ascii in pa.c.

> I don't think so, there is also a tab missing.  I think STRING_ASM_OP for
> hppa-linux should be changed to "\t.stringz\t".  OK?
> 
> Andreas.
> 
> 2006-05-19  Andreas Schwab  <schwab@suse.de>
> 
> 	* config/pa/pa-linux.h (STRING_ASM_OP): Prepend and append a tab.

Ok; but only because it will make the assembler output look better,
and we shouldn't have an assembler directive at the beginning of a line.

For 32-bit hpux, the regexp should be fixed.

Thanks,
Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]