This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add word-sized conversion functions to libgcc2
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Adam Nemet <anemet at caviumnetworks dot com>, gcc-patches at gcc dot gnu dot org, roger at eyesopen dot com, mark at codesourcery dot com, richard at codesourcery dot com
- Date: Wed, 17 May 2006 11:57:31 -0700
- Subject: Re: [PATCH] Add word-sized conversion functions to libgcc2
- References: <17512.10364.797535.170801@localhost.localdomain> <87sln84jw1.fsf@talisman.home>
Richard Sandiford wrote:
> This message is probably going to annoy you, sorry, because I'm going
> to propose an alternative patch. However, even if we go with that
> alternative patch, your description of the problem has surely helped
> me get this far. I'll leave it up to the reviewer (hi Mark!) to decide
> which approach to go for, or whether we should do something else entirely.
I like Richard's patch best. I find Richard's point about making names
of object files, etc., match the intuitive names implied by the various
mode-conversion routines compelling, and, I like that we're eliminating
some duplicate code.
> +# LIB2LITERAL_CONVERSION_MODES
I didn't find the name of this variable mnemonic; it took me a bit of
puzzling to figure out what it meant. How about
LIB2_CONVERSION_FUNC_NAMES_USE_ACTUAL_MODES? But, this is bikeshed
material; if you don't like my name, use your original one, or one of
your choosing, without feeling you ought to consult with me.
Please test, and, assuming no problems, apply.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713