This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Fwd: [Bug bootstrap/27644] [4.1 regression] Bootstrap failure on native ARM targets]
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: Mark Mitchell <mark at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 17 May 2006 11:46:01 -0700
- Subject: Re: [Fwd: [Bug bootstrap/27644] [4.1 regression] Bootstrap failure on native ARM targets]
- References: <20060517181550.GA26686@lucon.org> <200605171821.k4HIL7A7014027@earth.phy.uc.edu>
On Wed, May 17, 2006 at 02:21:07PM -0400, Andrew Pinski wrote:
> >
> > On Wed, May 17, 2006 at 10:43:06AM -0700, Mark Mitchell wrote:
> > >
> > > OK, that's enough alarm bells for me.
> > >
> > > HJ, please revert this series of patches on the 4.1 branch. I think
> > > it's likely that there will be fallout on other architectures as well.
> > > Please investigate the ARM failure on mainline ASAP.
> > >
> >
> > I sure can do that. According to options.texi
> >
> > ---
> > @item VarExists
> > The variable specified by the @code{Var} property already exists.
> > No definition should be added to @file{options.c} in response to
> > this option record.
> >
> > You should use this property if an earlier option has already declared
> > the variable or if the variable is declared outside @file{options.c}.
> > ---
>
> The variable does exist already as it is there already once in the .opt file.
>
> Please clean up the documention also to say you don't need VarExists if it
> is also defined in the .opt file.
>
Here is the updated patch.
H.J.
---
2006-05-17 H.J. Lu <hongjiu.lu@intel.com>
* config/arm/arm.opt (target_fpe_name): Remove VarExists.
* config/rs6000/rs6000.opt (TARGET_NO_FP_IN_TOC): Likewise.
* doc/options.texi (VarExists): Updated.
--- gcc/config/arm/arm.opt.exist 2005-11-04 14:14:00.000000000 -0800
+++ gcc/config/arm/arm.opt 2006-05-17 11:10:33.000000000 -0700
@@ -77,7 +77,7 @@ Target RejectNegative Joined Var(target_
Specify if floating point hardware should be used
mfp=
-Target RejectNegative Joined Undocumented Var(target_fpe_name) VarExists
+Target RejectNegative Joined Undocumented Var(target_fpe_name)
;; Now ignored.
mfpe
--- gcc/config/rs6000/rs6000.opt.exist 2006-03-19 15:06:12.000000000 -0800
+++ gcc/config/rs6000/rs6000.opt 2006-05-17 11:10:21.000000000 -0700
@@ -144,7 +144,7 @@ Target Report RejectNegative Var(TARGET_
Do not place floating point constants in TOC
mfp-in-toc
-Target Report RejectNegative Var(TARGET_NO_FP_IN_TOC,0) VarExists
+Target Report RejectNegative Var(TARGET_NO_FP_IN_TOC,0)
Place floating point constants in TOC
mno-sum-in-toc
--- gcc/doc/options.texi.exist 2006-05-16 15:52:13.000000000 -0700
+++ gcc/doc/options.texi 2006-05-17 11:41:51.000000000 -0700
@@ -169,8 +169,8 @@ The variable specified by the @code{Var}
No definition should be added to @file{options.c} in response to
this option record.
-You should use this property if an earlier option has already declared
-the variable or if the variable is declared outside @file{options.c}.
+You should use this property only if the variable is declared outside
+@file{options.c}.
@item Init(@var{value})
The variable specified by the @code{Var} property should be statically