This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: Run init tests only when __cxa_atexit is supported.
- From: Mark Mitchell <mark at codesourcery dot com>
- To: sje at cup dot hp dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 15 May 2006 16:01:54 -0700
- Subject: Re: Patch: Run init tests only when __cxa_atexit is supported.
- References: <200605152012.NAA14769@hpsje.cup.hp.com>
Steve Ellcey wrote:
> The 3 tests included here will only pass on systems that have an
> implementation of __cxa_atexit. This change is to use the
> dg-require-cxa-atexit check that I brought over from the libstdc++
> testsuite to check for __cxa_atexit and only run the tests on systems
> that have __cxa_atexit.
>
> Ok to checkin?
I agree with Andrew that, in theory, XFAILing these tests would be
better. If it's easy to do a conditional XFAIL that would be better.
Otherwise, this version is fine -- the only downside is that if we
somehow fix this bug without using __cxa_atexit, these tests still won't
be run.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713