This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MIPS64 soft-float: missing definition for __floatdidf and friends


Richard Sandiford writes:
> Adam Nemet <anemet@caviumnetworks.com> writes:
> > Yes but this seems to be the approach Roger had taken in his original
> > patch which you have positively commented on.
> 
> I could be wrong, but I didn't think Roger's patch copied very much
> existing code from libgcc2.c.  Most of it looked new.  E.g. floatditf.c
> adds two DFmode values to get the TFmode result, which was something
> I didn't think libgcc2.c had code to do.

Because he copied it from ppc64-fp.c which implements floatditf in
terms of float*sidf whereas libgcc2 implements it in terms of
float*sitf.  But it does not change the fact that we already had a
suitable floatditf template in libgcc2 and the patch did not use it.

Adam


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]