This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed] PR target/25871: Fix MIPS trampolines for Pmode == DImode

Richard Sandiford wrote:
I've applied Joshua Kinard's patch for PR 25871, in which the MIPS
nested function trampolines had 32-bit pointer moves even when
Pmode == DImode.

The bug isn't a regression, so I've not applied it to release branches.
However, the patch seems very safe to me, and should only affect people
for whom the current code doesn't work, so I'd be happy for it to be
applied to release branches too.

I can't test n64 myself right now, and mipsisa64-elf isn't much of a
test, because even though EABI64 has 64-bit pointers, a normal
mipsisa64-elf test will only use 32-bit pointer values.  I'll therefore
rely on the Gentoo testing that Joshua did and on the testing that
Joseph Myers has done on a CodeSourcery release branch.  I also tested
a mips-elf cross as a sanity check.  Applied to mainline.


Just a note, It was Stanislaw Skowronek <> who discovered the flaw and made the original patch (while working on a bootloader for sgimips systems). I adapted it to latest gcc and posted it to bugzilla.

Just giving credit where credit is due :)


Gentoo/MIPS Team Lead
Gentoo Foundation Board of Trustees

"Such is oft the course of deeds that move the wheels of the world: small hands do them because they must, while the eyes of the great are elsewhere." --Elrond

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]