This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR15911, VRP not handling TRUTH_AND/OR_EXPR
- From: Diego Novillo <dnovillo at redhat dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 02 May 2006 10:01:45 -0400
- Subject: Re: [PATCH] Fix PR15911, VRP not handling TRUTH_AND/OR_EXPR
- References: <Pine.LNX.4.64.0605012312440.17934@t148.fhfr.qr>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Richard Guenther wrote:
> + /* We cannot handle float types at all and will ICE in
>
s/We cannot/VRP does not/
> ! static bool
> ! register_edge_assert_for_1 (tree op, enum tree_code code,
> ! edge e, block_stmt_iterator bsi)
>
Missing documentation on return value.
What's the compile-time impact? What about the Ada regression mentioned
in the PR trail?
I'm not too keen on accepting enhancement fixes during stage 3, so
unless you have a powerful pressing need for this enhancement, I would
rather wait for stage 1. VRP changes have historically caused grief in
some areas.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
iD8DBQFEV2ZJUTa2oAUaiwQRAmzIAJ9zI9J00iz9a36lQwD1kBfoI1uUjwCfcT79
uKAYdvWFrtQAqiSeXZ2A6xM=
=fjHw
-----END PGP SIGNATURE-----