This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [gomp] Fix a couple of global var handling bugs, add firstprivate+lastprivate barrier (PR c++/26943)
- From: Richard Henderson <rth at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Diego Novillo <dnovillo at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 1 May 2006 12:47:03 -0700
- Subject: Re: [gomp] Fix a couple of global var handling bugs, add firstprivate+lastprivate barrier (PR c++/26943)
- References: <20060501170611.GD14147@devserv.devel.redhat.com>
On Mon, May 01, 2006 at 01:06:11PM -0400, Jakub Jelinek wrote:
> + /* Global variables don't need to be copied,
> + the receiver side will use them directly.
> + For nested contexts we unfortunately don't know
> + yet whether it will be a global variable or not. */
> + if (! ctx->is_nested && is_global_var (decl))
> + break;
> if (! TREE_READONLY (decl)
What's the test case for this? Just testing is_nested doesn't
seem quite right. I should think that we ought to be able to
tell, at some point whether it is or isn't. Perhaps a variant
of lookup_decl_in_outer_ctx?
r~