This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Avoid creating TREE_OVERFLOW constants in convert_to_integer (PR middle-end/26729)


Bootstrapped/regtested on x86_64-linux, ok for trunk/4.1?

Please do not put this on the 4.1 branch. Kazu's patch has already introduced
regressions for Ada there (which have not been fixed yet) and I think your
patch could introduce more.



Errr, either it does or it doesn't.


If it's been regtested on 4.1, and doesn't cause regressions in the Ada testsuite, it doesn't cause regressions in the Ada testsuite (at least for that platform).

If you want to say "look, i've tested it against our internal tests, and it causes a regression there, here's a testcase", that's fine.

But we shouldn't be blocking people from putting things on release branches that fix bugs if they've gone through the required testing. At least, that's not the policy we have documented.

--
Eric Botcazou



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]