This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR c++/26739: ICE on template redefinition as friend
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Volker Reichelt <reichelt at igpm dot rwth-aachen dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 19 Apr 2006 09:24:34 -0700
- Subject: Re: [patch] Fix PR c++/26739: ICE on template redefinition as friend
- References: <tkrat.33fec36b841b56fa@igpm.rwth-aachen.de>
Volker Reichelt wrote:
> 2006-04-18 Volker Reichelt <reichelt@igpm.rwth-aachen.de>
>
> PR c++/26739
> * pt.c (tsubst_friend_function): Return early if
> pushdecl_namespace_level fails.
This patch is OK.
I would modify the error markers in the test to mention a word from the
actual messages so that the ICE message no longer matches. The old-deja
tests are actually dg tests too (after I converted them a few years
back), but with slightly different defaults; however, all the same
general principles apply.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713