This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 3rd ping][cft] aligning main's stack frame: take 2


On Mon, Apr 03, 2006 at 09:27:58AM -0700, Stuart Hastings wrote:
> 	http://gcc.gnu.org/ml/gcc-patches/2006-03/msg01263.html

(1) I don't think your handling of regparm interaction is correct.
You should be generating an error for functions with 3 regparm
parameters, and the attribute set.

(2) You can choose *any* register that's free on function entry
and function exit.  So a nested function returning void and no
regparm could choose either eax or edx.  The register is *not*
handled like the pic register and reserved for the life of the
function -- your documentation is incorrect on that score.

(3) I'm not sure of the utility of the command line option.  Since
this isn't an alternate entry point, but rather an alternate
prologue, the overhead for compiling all functions with this could
be severe.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]