This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix wchar_t breakage on Solaris


Hi Eric,

Hi,

wchar_t support has been broken on Solaris < 10 in GCC 4.1.0. Tested on SPARC/Solaris 7, 8 and 9 as well as on AMD64/Linux, OK for mainline and 4.1 branch?


thanks for your help about this issue. I'm afraid the patch is incomplete, however: std_cwchar.h should be consistently adjusted and that, sadly, is not totally straightforward (like it is for wcstof, for instance) because of the C99_DYNAMIC machinery (used by freebsd only, AFAIK).

Anyway, I think it's fine simply #undef-ing conditional to the new macros, then using in NAMESPACE(__gnu_cxx) conditional to the macros and, again, using in NAMESPACE(std) conditional to the macros. I don't know if you are willing to manage the tangle... ;) just let me know, otherwise. Please liberally add comments, in case.

Also, given the comment at the beginning of the existing separate AC_TRY_COMPILE, I think a one-line new comment mentioning Solaris 7-9 is in order in acinclude.m4 too.

Thanks again,
Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]