This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix gcc.dg/visibility-11.c testcase
- From: "Kaveh R. Ghazi" <ghazi at caipclassic dot rutgers dot edu>
- To: jakub at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org, jason at redhat dot com
- Date: Wed, 29 Mar 2006 16:22:19 -0500 (EST)
- Subject: Re: [PATCH] Fix gcc.dg/visibility-11.c testcase
- References: <20060329205829.GK8410@devserv.devel.redhat.com>
> 2) only runs the test on linux/bsds, as it will fail on non-ELF targets
> +/* { dg-do compile { target { { i?86-*-linux* x86_64-*-linux* i?86-*-*bsd* x86_64-*-*bsd* } && ilp32 } } } */
Since you've moved the testcase to gcc.target/i386, I think you can
leave out the CPU. You can also add in other targets that are ELF and
still pass right? How about:
/* { dg-do compile { target { { *-*-linux* *-*-*bsd* *-*-solaris2* *-*-elf* *-*-gnu* *-*-sysv[45]* } && ilp32 } } } */
> [...]
> +/* { dg-options "-Os -fpic" } */
Pedantically, for the above we should have:
/* { dg-require-effective-target fpic } */
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu