Re: [avr]: conversion to define_constraint

[Zack Weinberg <zackw at panix dot com>]

On Tue, Mar 28, 2006 at 07:19:54PM +0400, Denis Chertykov wrote:
> Because 'converts some #defines and some magic numbers' too simple.
> I think that I needn't in rewiev I'm already committed the patch.

So that's fine, but really, if you're asking for comments on a patch,
please don't have *anything* unrelated in there.  You could have, say,
posted the define_constants patch with an "I'm checking this in, it's
obvious" note, and then the define_constraints patch.

> > You put the bulk of the logic for constraint "Q" in an avr.c
> > function, which is called only from the constraint definition.
> > Would you prefer to be able to write a C code block in the
> > constraint definition, as can be done for predicates?  It would not
> > be hard to add support for this to genpreds.  [I am willing to code
> > this but not till early April.]
>
> I don't like a big C blocks inside RTL because of difficulties with
> debugging.  I will convert an AVR port to define_predicate later.

Fair enough - but then I'm not going to bother doing the C code blocks
in define_*_constraint, unless someone else wants 'em.  :)

zw