This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libgloss psignal declaration [PATCH]
- From: "Shaun Jackman" <sjackman at gmail dot com>
- To: "DJ Delorie" <dj at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 21 Mar 2006 17:16:27 -0700
- Subject: Re: libgloss psignal declaration [PATCH]
- References: <7f45d9390510261500g1afa01b5r@mail.gmail.com> <200510262319.j9QNJUjC029181@greed.delorie.com>
- Reply-to: "Shaun Jackman" <sjackman at gmail dot com>
On 10/26/05, DJ Delorie <dj@redhat.com> wrote:
> > I found the following patch necessary to build libiberty with newlib
> > headers. Although, glibc seems to use the same signature now.
>
> While I'm generally OK with this...
...
> 3. If you have a psignal prototype, you should have a psignal
> function, and thus should not be compiling this code at all. Thus,
> something else is broken. Look for newlib-specific code in
> configure.ac.
>
> I suggest leaving the prototype as-is until #3 is resolved, since the
> conflict tells you when it's still broken.
Since some targets may provide a particular function, and some may
not, the trend in newlib has been to supply complete headers
regardless of the target's completeness. If I add the missing
documentation, would this patch be accepted?
Cheers,
Shaun
2005-10-26 Shaun Jackman <sjackman@gmail.com>
* libiberty/strsignal.c (psignal): Change the signo parameter from
unsigned to int, and message from char * to const char *.
Index: libiberty/strsignal.c
===================================================================
RCS file: /cvs/src/src/libiberty/strsignal.c,v
retrieving revision 1.9
diff -u -r1.9 strsignal.c
--- libiberty/strsignal.c 28 Mar 2005 02:09:01 -0000 1.9
+++ libiberty/strsignal.c 26 Oct 2005 21:56:29 -0000
@@ -549,7 +549,7 @@
#ifndef HAVE_PSIGNAL
void
-psignal (unsigned signo, char *message)
+psignal (int signo, const char *message)
{
if (signal_names == NULL)
{