This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] PR 22600: Exit code should be different from 1 for ICE

From: David Daney <ddaney at avtrex dot com>
To: Mark Mitchell <mark at codesourcery dot com>
Cc: Volker Reichelt <reichelt at igpm dot rwth-aachen dot de>, gcc-patches at gcc dot gnu dot org
Date: Tue, 21 Mar 2006 09:53:25 -0800
Subject: Re: [patch] PR 22600: Exit code should be different from 1 for ICE
References: <tkrat.7c35c1521de0b236@igpm.rwth-aachen.de> <441FE352.3000306@codesourcery.com>

Mark Mitchell wrote:

Volker Reichelt wrote:

I already posted a similar patch once, and Mark answered:

I don't think we need a switch; this should just be the default. We also need a documentation update to mention this.

I still agree with me. :-)

The problem is that the switch is already there.

But, this is a good point.
The Fortran frontend already uses "4" for this purpose, so I went
with this choice.
OK.
+/* If we don't have an overriding definition, set ICE_EXIT_CODE to 4.  */
+#ifndef ICE_EXIT_CODE
+# define ICE_EXIT_CODE 4
+#endif
Why not just unconditionally define this?  Let's make everyone play by
the same rules.
OK with that change.

This is nice, although I am not volunteering to do the work, I think we should modify the testsuite to pass this option too.

Right now there is no way to distinguish a normal XFAIL with an ICE on a test case that is expected to fail.

This is PR 24128.

David Daney.

References:
- [patch] PR 22600: Exit code should be different from 1 for ICE
  - From: Volker Reichelt
- Re: [patch] PR 22600: Exit code should be different from 1 for ICE
  - From: Mark Mitchell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]