Re: [PATCH] Enhanced nested functions lowering pass

[Eric Botcazou <ebotcazou at adacore dot com>]

> Errr, you haven't added one small function.

Indeed, but that's not what I said either...

> Also, you haven't really addressed the issue: cgraph already knows
> exactly how to do what your patch below adds, you just want to run that
> analysis on your nested functions.

I explained why.

> Even if you didn't go that far, At the very least, you could remove
> almost all the ni_map, reachable flags, etc, you've added below, and
> just use the ones on the cgraph nodes.

Yes, that could indeed be deemed an improvement.  The drawback is that this 
may break the interface/implementation separation for the cgraph API (see 
below).

> That would remove *most* of the patch you've submitted, and only leave
> the tree walking portion.  That may be more palatable to Richard (though
> maybe not. It looks almost exactly like record_reference).

Yes, that's the one small function I was talking about.  My understanding is 
that either I hack the cgraph machinery and export some internal stuff or I 
don't hack it and keep the separation.

-- 
Eric Botcazou