This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix cgraph_check_inline_limits
- From: Richard Guenther <rguenther at suse dot de>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Jan Hubicka <jh at suse dot cz>
- Date: Mon, 13 Mar 2006 14:27:38 +0100 (CET)
- Subject: Re: [PATCH] Fix cgraph_check_inline_limits
- References: <Pine.LNX.4.64.0603131304140.5416@t148.fhfr.qr>
On Mon, 13 Mar 2006, Richard Guenther wrote:
>
> This patch fixes two things in cgraph_check_inline_limits, for one,
> we were confused as to what callee list to walk (resulting in
> times == 0 always), second, we decided not to inline even if the
> inlining would result in the inlined-to-function size to shrink
> (if it is already > its limit due to always_inline functions).
>
> I'll bootstrap & regtest with a gcc_assert (times > 0) and put the
> patch on the internal various-c++ tests machine this night.
>
> Does this look reasonable?
Boostrapped and regtested on x86_64-unknown-linux-gnu with the assert
added.
Ok for mainline and 4.1 branch after a while?
Thanks,
Richard.
> 2006-03-13 Richard Guenther <rguenther@suse.de>
>
> * ipa-inline.c (cgraph_check_inline_limits): Walk the correct
> node for the callees. Always allow inlining if it will shrink
> the function size.