This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix darwin/25908, key functions vs non weak vtables

Mike Stump wrote:
> On Mar 2, 2006, at 1:42 PM, Mark Mitchell wrote:
>> Yes, please.  There's no virtue in having redundant code.
> 
> Ok?

Assuming this was tested in the usual way, yes.

>> The obvious rule is intended to capture cases that are patently obvious,
>> i.e., changes where no reasonable reviewer would object to the code.
> 
> Ah, ok.  That didn't quite match the rule I've been using.  I had been
> using the obvious to the writer rule, which is slightly different; I'll
> update my notion of the rule...

Good, thanks.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]