This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [m68k] some testsuite cleanups
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Andreas Schwab <schwab at suse dot de>
- Date: Tue, 21 Feb 2006 08:51:07 -0800
- Subject: Re: [m68k] some testsuite cleanups
- References: <43FB2CD8.7090202@codesourcery.com>
Nathan Sidwell wrote:
> This patch fixes some testsuite fails on coldfire. With my recent
> binutils changes, the spl1 test gratuitously failed to compile because
> of the use of the -m68000 flag would conflict with a -m5200 or other
> coldfire selection flag.
I don't understand why -m68000 was there, so I'll let Andreas answer.
It makes sense to me to run the test unconditionally with -O2, as you
suggest.
> The static11 test doesn't work on bare boards, as the comment already
> there indicates, so I xfail it.
Definitely OK.
> Similarly thunk2 has an out-of-range relocation.
That test is already guarded with "{target fpic}"; is it the case that
PIC doesn't really work on this target, or is it just that PIC works,
but this test fails? It doesn't look like there's anything about that
test that should be so difficult to support. It might still make sense
to XFAIL it, if it fails in practice, but is there a bug that needs fixing?
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713