This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't call gfc_finish_var_decl on length decls (PR fortran/26246)
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Mon, 13 Feb 2006 11:01:28 -0800
- Subject: Re: [PATCH] Don't call gfc_finish_var_decl on length decls (PR fortran/26246)
- References: <20060213143629.GR24295@devserv.devel.redhat.com>
On Mon, Feb 13, 2006 at 09:36:30AM -0500, Jakub Jelinek wrote:
>
> As shown on the attached two testcases, calling gfc_finish_var_decl
> is a bad idea for the length decls. gfc_add_decl_to_function
> does all that is needed, we know those decls aren't Cray pointers/pointees,
> aren't module variables, aren't threadprivate, etc.
>
> Tested with make check-fortran, full bootstrap will start RSN.
> Ok for trunk?
>
> 2006-02-13 Andrew Pinski <pinskia@physics.uc.edu>
> Jakub Jelinek <jakub@redhat.com>
>
> PR fortran/26246
> * trans-decl.c (gfc_get_symbol_decl, gfc_get_fake_result_decl): Use
> gfc_add_decl_to_function rather than gfc_finish_var_decl on length.
>
> * gfortran.dg/pr26246_1.f90: New test.
> * gfortran.dg/pr26246_2.f90: New test.
>
OK.
--
Steve