This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Clean up dump_file usage

From: Bernd Schmidt <bernds_cb1 at t-online dot de>
To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
Cc: gcc-patches at gcc dot gnu dot org, dnovillo at redhat dot com
Date: Mon, 06 Feb 2006 13:23:32 +0100
Subject: Re: [patch] Clean up dump_file usage
References: <20060205214323.GA29117@atrey.karlin.mff.cuni.cz>

Zdenek Dvorak wrote:

when I attempted to implement a way how to control dump details level
more precisely, I run into problems, since throughout the ages, we
devised various clever ways how to (miss)use dump files.  This patch
attempts to clean up it a bit.  It ensures that (up to a few exceptions),
the following rules are observed:

1) All the dumps go to dump_file, directly using the global variable
   (in several passes, we were either passing dump_file around in
   arguments, or assigned it to a local static variable, or even used
   a higher level of magic -- see e.g. profile_dump_file).

I thought we were already doing that.

I spot-checked your patch (e.g. to make sure things like print_rtl still take FILE * arguments), and it's OK for mainline.

Bernd

References:
- [patch] Clean up dump_file usage
  - From: Zdenek Dvorak

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]