This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Clean up loop structures initialization/updating
- From: Roger Sayle <roger at eyesopen dot com>
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 5 Feb 2006 10:37:59 -0700 (MST)
- Subject: Re: [patch] Clean up loop structures initialization/updating
On Sun, 5 Feb 2006, Zdenek Dvorak wrote:
> * tree-vrp.c (cfg_loops): Removed.
> (adjust_range_with_scev, vrp_visit_assignment, execute_vrp):
> Use current_loops instead of cfg_loops. Pass flags to
> loop_optimizer_init.
> * cfgloopmanip.c (fix_loop_structure): Update only available
> information.
> * tree-ssa-loop-ch.c (copy_loop_headers): Pass flags to
> loop_optimizer_init.
> * modulo-sched.c (build_loops_structure): Removed.
> (sms_schedule): Use loop_optimizer_init.
> * loop-init.c (loop_optimizer_init): Use flags to determine
> which properties of loops to prepare.
> (rtl_loop_init): Pass flags to loop_optimizer_init.
> * tree-ssa-sink.c (execute_sink_code): Ditto.
> * tree-ssa-loop.c (tree_loop_optimizer_init): Ditto.
> * tree-ssa-pre.c (init_pre): Ditto.
> * cfgloop.h (LOOPS_NORMAL): New.
> (loop_optimizer_init): Declaration changed.
This is OK for mainline with one minor typo/style tweak:
> Index: tree-ssa-loop.c
> ===================================================================
> *** tree-ssa-loop.c (revision 110593)
> --- tree-ssa-loop.c (working copy)
> *************** struct loops *current_loops = NULL;
> *** 48,54 ****
> static struct loops *
> tree_loop_optimizer_init (FILE *dump)
> {
> ! struct loops *loops = loop_optimizer_init (dump);
>
> if (!loops)
> return NULL;
> --- 48,58 ----
> static struct loops *
> tree_loop_optimizer_init (FILE *dump)
> {
> ! struct loops *loops;
> !
> !
> ! loops = loop_optimizer_init (dump, (LOOPS_NORMAL
> ! | LOOPS_HAVE_MARKED_SINGLE_EXITS));
>
> if (!loops)
> return NULL;
Just one blank line between declarations and executable statements.
Thanks,
Roger
--