This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR 17886


Andrew Pinski wrote:
> 
> On Sep 29, 2005, at 4:44 PM, Falk Hueffner wrote:
> 
>> shouldn't first_pass_p be initialized to true? (and if so, why was
>> there no warning?)
> 
> 
> The warning is recorded as PR 18501.

That's really weird; I bootstrapped the patch, and didn't get an error;
I would have thought -Werror would have caused a failure.  Oh, I see,
you're saying that the *lack* of warning is the PR.

In any case, I've checked in this patch, as obvious, after confirming
that "make cc1" worked.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304
2005-09-29  Mark Mitchell  <mark@codesourcery.com>

	* optabs.c (expand_binop): Initialize first_pass_p.

Index: optabs.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/optabs.c,v
retrieving revision 1.296
diff -c -5 -p -r1.296 optabs.c
*** optabs.c	29 Sep 2005 14:57:21 -0000	1.296
--- optabs.c	29 Sep 2005 21:47:21 -0000
*************** expand_binop (enum machine_mode mode, op
*** 1025,1035 ****
  		  || binoptab->code == LSHIFTRT
  		  || binoptab->code == ROTATE
  		  || binoptab->code == ROTATERT);
    rtx entry_last = get_last_insn ();
    rtx last;
!   bool first_pass_p;
  
    class = GET_MODE_CLASS (mode);
  
    /* If subtracting an integer constant, convert this into an addition of
       the negated constant.  */
--- 1025,1035 ----
  		  || binoptab->code == LSHIFTRT
  		  || binoptab->code == ROTATE
  		  || binoptab->code == ROTATERT);
    rtx entry_last = get_last_insn ();
    rtx last;
!   bool first_pass_p = true;
  
    class = GET_MODE_CLASS (mode);
  
    /* If subtracting an integer constant, convert this into an addition of
       the negated constant.  */

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]