This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR fortran/24005


On Fri, Sep 23, 2005 at 06:24:01AM +0200, Paul Thomas wrote:
> 
> >does "the right thing" with NULL arguments unlike FreeBSD's.  
> >Alternatively,
> >(if I understand C well enough) we could simply compare the string pointers
> >(they're allocated by gfc_get_string) like so:
> > 
> >
> Yes indeed.  Sometime, we should do a trawl through the compiler to 
> ensure that they ar all allocated by gfc_get_string and to reduce the 
> number strcmp's thereby.
> 

I did a "grep strcmp *c | grep sym" earlier today.  There
are only one or two other candidates for eliminating the
strcmp.  Most of the remaining cases are of the form

some_function(char *name, gfc_some_struct p) {

  if (strcmp(name, p->name) == 0)

}


BTW, I've been running one of your module.c patches without
any problems.  In fact, I spent part of the day trawling the
internet for module heavy F90 code, and could compile everything
I downloaded.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]