Re: [PATCH] Fix gcc.c-torture/execute/20010124-1 on MIPS...

[David Daney <ddaney at avtrex dot com>]

Richard Henderson wrote:
> On Thu, Sep 08, 2005 at 05:40:23PM -0700, David Daney wrote:
>
> > > See testsuite/gcc.c-torture/execute/builtins/.
> >
> > I assume that by that you mean memops-asm-lib.c.
>
>
> No, I meant the whole directory.
>
>
> > They are declared without 'static'.  This is exactly what my patch does.
>
>
> Except that an important point is that the implementation of the
> memcpy is in a separate compilation unit from the test itself.

O.K.  Now I am starting to understand.

> > Any comments about the patch?
>
>
> Not sufficient.  Move the test to the builtins subdirectory.

Why?  It is a test of the assignment operator not a builtin.

I will go out on a limb here and hazard a guess that since builtins.exp 
is setup to link together two testsuite objects and that is what we need 
to do, that 20010124-1 should be split into two files and put in the 
execute/builtins directory even though it is not testing builtins.

Am I going down the correct path here?

Thanks,
David Daney.