This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] S/390 Bootstrap failure due to fixup_eh_region_note



On Sep 6, 2005, at 7:08 AM, Andreas Krebbel wrote:


Hello Richard,

I've done as you suggested and it is certainly no surprise for you
that the assertion in question is not triggered anymore.
Here is the patch I've tested.

Bootstrapped on s390, s390x and i686 no testsuite regressions.


+ /* We've possibly turned single trapping insn into multiple ones. */
+ if (flag_non_call_exceptions)
+ {
+ sbitmap blocks;
+ blocks = sbitmap_alloc (last_basic_block);
+ sbitmap_ones (blocks);
+ find_many_sub_basic_blocks (blocks);
+ }

But when I was looking into this bug, I noticed that the EH REGIONS are always throw external and never can throw internal so new basic blocks will not be found. The assert is correct for internal throw EH REGIONS reg notes but not correct for the external throw as we don't need a new basic block.

-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]