This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: gen_*_mem utility functions for stack accesses (Was: Re: MEM_NONTRAP_P and push/pop alias set)


Joern RENNECKE <joern.rennecke@st.com> writes:

> + /* Generate a memory referring to fixed portions of the frame, e.g., register
> +    save areas.  */

(I think "memory" should be "MEM", but I see that you are copying an
existing comment).

> + /* Generate a memory referring to a temporary value on the stack, e.g.
> +    something that is pushed / popped by a target splitter pattern.  */

I think this comment needs to be beefed up a bit--there are lots of
temporary values on the stack.  Maybe something like

    Generate a MEM referring to a temporary use of the stack, not part
    of the fixed stack frame.  For example, something which is pushed
    by a target splitter.

This is OK with a change along those lines (unless RTH has some other
idea in mind).

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]