Re: [patch] fix tree-optimization PRs: 22543 and 22228

[Dorit Naishlos <DORIT at il dot ibm dot com>]

Turns out I submitted a slightly older version of the patch than I intended
to - there's a tiny fix required (without it bootstrap fails). I'm
resubmitting the right patch now, which also includes the fix that Steven
suggested.

Bootstrapped (with vectorization enabled) on powerpc-darwin, tested on the
vectorizer tests.

ok to commit?

thanks,
dorit

      PR tree-optimization/22228
      * tree-ssa-loop (pass_vectorize): Add TODO_verify_loops to
todo_flags_start.
      * tree-vect-transform.c (vect_transform_loop): Mark the variables
that
      are recorded in vect_vnames_to_rename for renaming.
      * tree-vectorizer.c (vect_vnames_to_rename): New global bitmap.
      (slpeel_update_phi_nodes_for_guard1): Record virtual vars for
renaming
      in vect_vnames_to_rename.
      (vectorize_loops): Allocate and free the vect_vnames_to_rename
bitmap.
      * tree-vectorizer.h (vect_vnames_to_rename): New extern variable.


(See attached file: new_updatessa_patch)

Steven Bosscher <stevenb@suse.de> wrote on 14/08/2005 17:29:10:

> On Sunday 14 August 2005 16:26, Dorit Naishlos wrote:
> > > This change is wrong. You can't have a TODO_* flag in the
> > > properties_required field.  You should add it to the flags in
> > > the todo_flags_finish field.  And removing PROP_ssa is also
> > > wrong.  You _do_ need SSA form for the vectorizer.
> >
> > Of course I want SSA-form; I wanted to verify something stronger - that
> > it's in loop-closed-ssa-form *before* vectorization starts.  If there's
no
> > PROP for that, I guess I'll put back the PROP_ssa in
'properties_required'
> > and maybe add TODO_verify_loops in 'todo_flags_start'?
>
> Aha.  Well.  If TODO_verify_loops verifies that things are in loop-closed
> SSA form, then yes, adding it todo_flags_start is the right thing to do.
>
> Gr.
> Steven
>

Attachment: new_updatessa_patch
Description: Binary data