This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: unreviewed patch (ping N+1)

From: Aldy Hernandez <aldyh at redhat dot com>
To: Geoff Keating <geoffk at geoffk dot org>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 15 Aug 2005 21:52:24 -0400
Subject: Re: unreviewed patch (ping N+1)
References: <20050808221515.GA31585@redhat.com> <m2d5oof42d.fsf@greed.local> <20050808225424.GA32100@redhat.com> <FB578153-8874-457B-BCA9-1F7043D0564B@geoffk.org>

Hi Geoff.

Thanks for reviewing this!

> The sections in the .md file after the comment
> 
> + ;; ::::::::::::::::::::
> + ;; ::
> + ;; :: Constraints
> + ;; ::
> + ;; ::::::::::::::::::::
> 
> should not be there, since they simply duplicate the texinfo  
> documentation.

Fixed.

> 
> There needs to be a section in the manual that documents the MS1- 
> specific constraints, derived from the comment above the SMALL_INT  
> macro definition.

Done.

> Otherwise, I think this is good, send a revised version with those  
> changes.

Attached.

OK?
Aldy

Attachment: curr.gz
Description: GNU Zip compressed data

Follow-Ups:
- Re: unreviewed patch (ping N+1)
  - From: Aldy Hernandez
- Re: unreviewed patch (ping N+1)
  - From: Geoff Keating

References:
- unreviewed patch (ping N+1)
  - From: Aldy Hernandez
- Re: unreviewed patch (ping N+1)
  - From: Geoffrey Keating
- Re: unreviewed patch (ping N+1)
  - From: Aldy Hernandez
- Re: unreviewed patch (ping N+1)
  - From: Geoff Keating

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]