This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix -dv (take 2)


On Thu, Aug 11, 2005 at 11:28:12AM +0200, Paolo Bonzini wrote:
> >There is another problem, with GCC 4+ print_rtl_graph_with_bb
> >is never called when -dv is requested, so all the vcg files contain just:
> >graph: {
> >port_sharing: no
> >}
> 
> Hum, this worked after my patch at 
> http://gcc.gnu.org/ml/gcc-patches/2004-08/msg00853.html that unified the 
> handling of dump files for trees and RTL; however, the relevant hunk 
> went away with revision 2.56 of tree-optimize.c.
> 
> The following patch fixes it.  I only tested by bubblestrap, because VCG 
> printing is not covered by the testsuite.
> 
> Ok for mainline?

This is not enough, on HEAD you end up with *.vcg files only containing
} and newline.

But if print_rtl_with_bb should be run from execute_todo rather than
execute_one_pass, here is the patch that does the job for me.
I have noticed GCC 4.0 code being pretty different, so I have prepared
a separate 4.0 version as well.

On 4.0 branch, clean_graph_dump_file is called by close_dump_file,
so it is both superfluous to call it also in execute_one_pass and
additionally calling it there also introduces the ICE.

	Jakub

Attachment: gcc41-dv.patch
Description: Text document

Attachment: gcc4-dv.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]