This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix-includes for darwin's math.h testing __APPLE_CC__instead of __GNUC__
- From: Bruce Korb <bruce_korb at symantec dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: patch Patches <gcc-patches at gcc dot gnu dot org>, Geoffrey Keating <geoffk at geoffk dot org>, bkorb at gnu dot org
- Date: Tue, 09 Aug 2005 11:58:56 -0700
- Subject: Re: [PATCH] fix-includes for darwin's math.h testing __APPLE_CC__instead of __GNUC__
- References: <04b4a63c3fdcfa01a7bac64a48cb0a19@physics.uc.edu>
Andrew Pinski wrote:
OK? Bootstrapped and tested on powerpc-darwin with no regressions (and
tested fix-includes
also with no regressions).
Looks okay to me, excep why bother with testing at all?
The GCC version is known at cvs checkout time, so a
compile time check seems unnecessary. :)
How about this?
+/*
+ * Fixup Darwin's broken check for __builtin_nanf.
+ */
+
+fix = {
+ hackname = broken_nan;
+ files = "architecture/ppc/math.h";
+ files = "architecture/i386/math.h";
+ select = "#if defined(__APPLE_CC__) && (__APPLE_CC__ >= 1345)";
+ bypass = "powl";
+ c_fix = format;
+ c_fix_arg = "#if 1";
+};
+
BTW, the emailed patch spelled "c-fix-arg" as "c-fxi-arg" and
could never have worked as intended.
Cheers, Bruce