This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Fix PR23128 and PR23129
- From: Diego Novillo <dnovillo at redhat dot com>
- To: Jeffrey A Law <law at redhat dot com>
- Cc: "James A. Morrison" <ja2morri at csclub dot uwaterloo dot ca>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 1 Aug 2005 15:59:30 -0400
- Subject: Re: [Patch] Fix PR23128 and PR23129
- References: <kfh1x5fwvtg.fsf@csclub.uwaterloo.ca> <1122922153.8684.37.camel@localhost.localdomain>
On Mon, Aug 01, 2005 at 12:49:13PM -0600, Jeffrey A Law wrote:
> I really find range_includes_zero_p to be somewhat misleading. It'll
> return true for ~[0, 0], even though clearly zero is not within that
> range.
>
> I suspect the poor name and comments will be a source of ongoing
> problems if we don't fix it now.
>
Good point. Fixing it will affect the new changes in
ABS_EXPR/MINUS_EXPR handling. James, would you have time to fix
this inconsistency?