This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix Ada bootstrap on ppc-darwin & x86_64


On Mon, Jul 25, 2005 at 11:59:24PM +0200, Laurent GUERBY wrote:
> A slightly updated version per Andrew comments in bugzilla, test results
> show no regression amd64-linux (and on x86):
> 
> http://gcc.gnu.org/ml/gcc-testresults/2005-07/msg01359.html
> 
> OK to commit?

No, not ok.

> > This patch fixes the Ada bootstrap on ppc-darwin by forcing Ada not to
> > produce ADDR_EXPR<CONSTRUCTOR> in its trees.  Note this really works
> > around a cgraph defect for non GENERIC trees but since everyone dealing
> > with trees have said that ADDR_EXPR<CONSTRUCTO> should not be used, I
> > decided this was the best way forward.

Depending on what cgraph is looking for, you can either hack around
this in LANG_HOOKS_CALLGRAPH_ANALYZE_EXPR, or we can bite the bullet
and change cgraph to lower to gimple before analysis.



r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]