This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] for PR 22594

From: Dave Murphy <wintermute2k4 at ntlworld dot com>
To: Geoff Keating <geoffk at apple dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Sun, 24 Jul 2005 15:22:17 +0100
Subject: Re: [patch] for PR 22594
References: <EDB14DD8-41C1-4518-BE12-58111C6B7F7D@apple.com>

Geoff Keating wrote:

diff -Naurb gcc-4.0.1/gcc/hwint.h gcc-4.0.1-new/gcc/hwint.h
--- gcc-4.0.1/gcc/hwint.h       Wed Nov 24 04:31:57 2004
+++ gcc-4.0.1-new/gcc/hwint.h   Thu Jul 21 14:37:06 2005
@@ -80,7 +80,7 @@
 #  define HOST_WIDE_INT_PRINT_DOUBLE_HEX "0x%lx%08lx"
 # endif
 #else
-# define HOST_WIDE_INT_PRINT "ll"
+# define HOST_WIDE_INT_PRINT HOST_LONG_LONG_FORMAT
 # define HOST_WIDE_INT_PRINT_C "LL"
   /* We can assume that 'long long' is at least 64 bits.  */
 # define HOST_WIDE_INT_PRINT_DOUBLE_HEX \

This is OK, with a suitable ChangeLog entry.

:REVIEWURL http://gcc.gnu.org/ml/gcc-patches/2005-07/msg01413.html :

is this ok? Or do I need to provide a patch against gcc/ChangeLog?

2005-07-21 Dave Murphy <wntrmute@sourceforge.net>

   PR 22594
   * gcc/hwint.h HOST_WIDE_INT_PRINT
   use HOST_LONG_LONG_FORMAT in HOST_WIDE_INT_PRINT macro instead of
   "ll" directly to allow override from gcc/config/i386/xm-mingw32.h

Follow-Ups:
- Re: [patch] for PR 22594
  - From: Daniel Berlin

References:
- Re:[patch] for PR 22594
  - From: Geoff Keating

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]