This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: C++ frontend bits for PR c/22476 -Wmissing-format-attribute


Kaveh R. Ghazi wrote:
The code added recently to enhance -Wmissing-format-attribute was
specific to the C frontend.  This patch moves some of the code to
c-common.c and adds the necessary bits to the C++ frontend so that g++
also gets this enhancement.

I couldn't find a single spot in the C++ frontend to insert the code
like I did for C.  Using 'convert_for_assignment' took care of assign,
init and return type, but I had to put an extra call in
'convert_for_arg_passing' to get function params.  Any suggestion on a
single (or better) location would be much appreciated.

Also, the move to c-common.c consolidation is independent and can go
in separately (first) if the C++ bits need refining.  I'm also going
to copy the C testcases over to the G++ testsuite.  (Are there any
additional C++ cases we should cover beyond the four we did for C?)

Okay for mainline?

OK.


--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]