This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Externalize data-ref analysis - part 1


Thank you for the patch.  I have detected a typo in the following code:

! #define DR_ACCESS_FNS(DR)\
!   (DR_TYPE(DR) == ARRAY_TYPE ?  \

you certainly mean ARRAY_REF_TYPE and not ARRAY_TYPE, because the
value of DR_TYPE should be in the following enum:

+ enum data_ref_type {
+   ARRAY_REF_TYPE,
+   POINTER_REF_TYPE
+ };

Same error occurs below, probably a cut and paste.  Other than these
typos I find the patch ok, unless Daniel has more comments.

If you can replace the occurences of "dot followed by a single space"
with a "dot followed by two spaces" at the end of some sentences in
the comments it would be great.

Thanks again.

Sebastian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]