This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, fortran] character length (PR fortran/21730)


On Sat, Jul 16, 2005 at 08:01:03AM -0700, Steve Kargl wrote:
> On Wed, Jul 13, 2005 at 02:56:44PM -0400, David Edelsohn wrote:
> > >>>>> Steve Kargl writes:
> > 
> > Steve> Do you have a testcase that fails without this patch?
> > 
> 
> (snip)
> 
> > I converted that to a gfortran testsuite testcase, again in the PR
> > 
> 
> (code snipped)
> 
> It makes it easier to review patches when testcases are provided
> with the patch. 
> 

Aargh.  I need another cup of coffee.

> I think the patch is ok to commit to mainline (and 4.0
> have regression testing).  I agree with comment to Feng
  after                                  ^your           ^that
> this patch fixes the reported.  The new bug involving
                               ^bug
> arrays can be treated a new PR, which I know you have open.
                       ^in                                  ^ed   
-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]