This is the mail archive of the
mailing list for the GCC project.
Re: Fix one of problems in profile updating code
- From: Jeffrey A Law <law at redhat dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 15 Jul 2005 16:26:48 -0600
- Subject: Re: Fix one of problems in profile updating code
- References: <20050715094941.GB23659@kam.mff.cuni.cz> <42D834D5.email@example.com>
- Reply-to: law at redhat dot com
On Fri, 2005-07-15 at 15:12 -0700, Mark Mitchell wrote:
> Jan Hubicka wrote:
> > Jeff,
> > with one of updates you killed code computing counts of duplicated block
> > in thread updating code. Please try to mind profile when modifying the
> > code further as it is getting bit dificult to figure out what jump
> > threading does and how to fix it and the code broke several times in the
> > past. This bug was responsible for quite large regression of art
> > benchmark and there still seems to be other problem described in
> > PR22401.
> Jeff, Honza --
> Is there something that can be done here to make it harder for people to
> make mistakes with profiling? This is an important feature, but one
> that not everyone uses. Like, is it possible to create a test case for
> the bug you just fixed so it doesn't happen again?
Or at least cobble together (and point everyone to) documentation
on what kinds of transformations will muck up the profiling
information and how to fix it.
Basically all the profiling stuff is a black box to me (and
possibly others). If I know what to look out for and how to
fix it, then, well, I'll do that.