This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC]: patch for PR c/22476 -Wmissing-format-attribute
> > + if (warn_missing_format_attribute)
>
> The documentation of -Wmissing-format-attribute will need updating, as
> will the warning that it does nothing without -Wformat (as these
> particular warnings don't seem to depend on -Wformat).
Ok I'll update the docs describing the new detection.
However WRT -Wformat I can make the new code additionally depend on
warn_format which seems more consistent with the old behavior, or
update the docs to reflect that some of the warnings happen always.
I'm not sure which is more appropriate.
> > + WARN_FOR_ASSIGNMENT (G_("argument %d of %qE might be "
>
> WARN_FOR_ASSIGNMENT uses pedwarn, but warning is appropriate here:
> these diagnostics shouldn't be errors with -pedantic-errors. So a
> switch statement rather than using the macro would seem appropriate
> here.
Ok will do.
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu