This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC]: patch for PR c/22476 -Wmissing-format-attribute


On Fri, 15 Jul 2005, Kaveh R. Ghazi wrote:

> +      if (warn_missing_format_attribute)

The documentation of -Wmissing-format-attribute will need updating, as 
will the warning that it does nothing without -Wformat (as these 
particular warnings don't seem to depend on -Wformat).

> +		WARN_FOR_ASSIGNMENT (G_("argument %d of %qE might be "

WARN_FOR_ASSIGNMENT uses pedwarn, but warning is appropriate here: these 
diagnostics shouldn't be errors with -pedantic-errors.  So a switch 
statement rather than using the macro would seem appropriate here.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]