This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix tree-opt/21840, FRE/PRE mismatch types in MODIFY_EXPR

From: Andrew Pinski <pinskia at physics dot uc dot edu>
To: Daniel Berlin <dberlin at dberlin dot org>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 12 Jul 2005 22:26:30 -0400
Subject: Re: [PATCH] Fix tree-opt/21840, FRE/PRE mismatch types in MODIFY_EXPR
References: <49836e5e2d1f42563d6c67dde45a1e2d@physics.uc.edu> <1121219927.13154.79.camel@linux-009002219143>

On Jul 12, 2005, at 9:58 PM, Daniel Berlin wrote:


This is fine.  Could you please add a small comment above the code
you've added saying something like

"We need to make sure the new and old types actually match, which may
require adding a simple cast, which fold_convert will do for us"

(or whatever)

Done.

Thanks,
Andrew Pinski

References:
- [PATCH] Fix tree-opt/21840, FRE/PRE mismatch types in MODIFY_EXPR
  - From: Andrew Pinski
- Re: [PATCH] Fix tree-opt/21840, FRE/PRE mismatch types inMODIFY_EXPR
  - From: Daniel Berlin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]