This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Your %b patch

From: Mark Mitchell <mark at codesourcery dot com>
To: Eric Christopher <echristo at redhat dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 11 Jul 2005 20:45:57 -0700
Subject: Re: Your %b patch
References: <42CE2EEC.6090909@codesourcery.com> <1121129654.3139.26.camel@dzur.sfbay.redhat.com>

Eric Christopher wrote:

OK, with that change.
Here's the patch. It's slightly different from what you asked, but works
just like you wanted.
Please also update the comment for "infile::language" to indicate the special "*" convention, and adjust the comment for your new code.
I'm not sure where you were meaning so i put it above the struct
definition. OK?

Yes, that's fine. (I normally put comments like that right above the field, but I'm not going to be (more of) a pedant about it.)

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304

References:
- Your %b patch
  - From: Mark Mitchell
- Re: Your %b patch
  - From: Eric Christopher

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]