This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] tree.c: Fix latent bugs in upper_bound_in_type and lower_bound_in_type.

From: Kazu Hirata <kazu at codesourcery dot com>
To: Mark Mitchell <mark at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 08 Jul 2005 15:08:46 -0400
Subject: Re: [patch] tree.c: Fix latent bugs in upper_bound_in_type and lower_bound_in_type.
References: <200507081359.j68Dx7B5030571@sethra.codesourcery.com> <20050708182514.GC19096@redhat.com>

Hi Mark,

	* tree.c (upper_bound_in_type): Fix calculations for casting
	to a non-wider signed type and casting a signed value to a
	wider unsigned type.
	(lower_bound_in_type): Fix calculations for casting to a
	non-wider signed type.

Ok.

Is this OK for 4.0.x after appropriate testing? The original post is at:

http://gcc.gnu.org/ml/gcc-patches/2005-07/msg00566.html

According to Andrew Pinski, the problem that my patch above fixes is a regression (PR22360), but I do not have any testcase that triggers the bug although I can trigger the bug with a fix for another bug. (That is, we have a latent bug here.)

Kazu Hirata

Follow-Ups:
- Re: [patch] tree.c: Fix latent bugs in upper_bound_in_type and lower_bound_in_type.
  - From: Mark Mitchell

References:
- [patch] tree.c: Fix latent bugs in upper_bound_in_type and lower_bound_in_type.
  - From: Kazu Hirata
- Re: [patch] tree.c: Fix latent bugs in upper_bound_in_type and lower_bound_in_type.
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]